Hi all contributors: My name is zeng Chen and in charge of the service of robot for openlookeng. Recently, some contributors ask me to manage the approvers and reviewers as this one which is already running on k8s. I think it is a good suggestion. I send this email to clarify how does that mechanism run.
1. How to manage approvers The approvers are managed though the OWNERS files which may exist at each level directories. An approver in an OWNERS file can approve(by adding approved label) any file in that directory and its sub-directories, but he/she can't approve the files in the parent directory and any other sibling directories.
2. How to add label of 'approved' Please see the example to get the details.
3. How to manage reviewers Like the way to manage the approvers, reviewers are managed by OWNERS file too. A reviewer in an OWNERS file can approve(by adding lgtm label) any file in that directory and its sub-directories, but he/she can't approve the files in the parent directory and any other sibling directories. This is the big change to before. The old mechanism is that any one of collaborators which are managed by the git platform such as Gitee, Github can add lgtm label. The purpose is to let the reviewer work as approver and make each files at different level directories reviewed by different reviewers.
4. How to add label 'lgtm' The process is also like approve process, see the example of adding approved label above.
In summary, both the approver and reviewer will be managed by OWNERS file and their working mechanisms are also the same. Appreciated for any suggestions. Thanks!
Best Wishes zeng chen
Sounds good. I see that we already maintain a OWNERS file in the hetu-core project. But it has only the "approvers" names. I believe the proposal is to also manage "reviewers" using the OWNERS file.
https://gitee.com/openlookeng/hetu-core/blob/master/OWNERS
Thanks, Sundar
On Mon, 27 Jul 2020 at 06:11, zengchen chenzeng765@163.com wrote:
Hi all contributors: My name is zeng Chen and in charge of the service of robot for openlookeng. Recently, some contributors ask me to manage the approvers and reviewers as this one https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md which is already running on k8s. I think it is a good suggestion. I send this email to clarify how does that mechanism run.
1. How to manage approvers The approvers are managed though the OWNERS files which may existat each level directories. An approver in an OWNERS file can approve(*by adding approved label*) any file in that directory and its sub-directories, but he/she can't approve the files in the parent directory and any other sibling directories.
2. How to add label of 'approved' Please see the examplehttps://github.com/kubernetes/test-infra/tree/master/prow/plugins/approve/approvers#example to get the details.
3. How to manage reviewers Like the way to manage the approvers, reviewers are managed byOWNERS file too. A reviewer in an OWNERS file can approve(*by adding lgtm label*) any file in that directory and its sub-directories, but he/she can't approve the files in the parent directory and any other sibling directories. *This is the big change to before. * The old mechanism is that any one of collaborators which are managed by the git platform such as Gitee, Github can add *lgtm *label. The purpose is to let the reviewer work as approver and make each files at different level directories reviewed by different reviewers.
4. How to add label 'lgtm' The process is also like approve process, see the example ofadding approved label above.
In summary, both the approver and reviewer will be managed by OWNERSfile and their working mechanisms are also the same. Appreciated for any suggestions. Thanks!
Best Wishes zeng chen _______________________________________________ Dev mailing list -- dev@openlookeng.io To unsubscribe send an email to dev-leave@openlookeng.io
Yes, this proposal wants to manage "reviewers" using the OWNERS file too. Reviewer can only add lgtm label, but approver can add lgtm and approved two labels. The approvers will add lgtm label on pr before adding reviewers to OWNERS file.
At 2020-07-28 00:04:44, "Sundar" sundarannamalai@gmail.com wrote:
Sounds good. I see that we already maintain a OWNERS file in the hetu-core project. But it has only the "approvers" names. I believe the proposal is to also manage "reviewers" using the OWNERS file.
https://gitee.com/openlookeng/hetu-core/blob/master/OWNERS
Thanks, Sundar
On Mon, 27 Jul 2020 at 06:11, zengchen chenzeng765@163.com wrote:
Hi all contributors: My name is zeng Chen and in charge of the service of robot for openlookeng. Recently, some contributors ask me to manage the approvers and reviewers as this one which is already running on k8s. I think it is a good suggestion. I send this email to clarify how does that mechanism run.
1. How to manage approvers The approvers are managed though the OWNERS files which may exist at each level directories. An approver in an OWNERS file can approve(by adding approved label) any file in that directory and its sub-directories, but he/she can't approve the files in the parent directory and any other sibling directories.
2. How to add label of 'approved' Please see the example to get the details.
3. How to manage reviewers Like the way to manage the approvers, reviewers are managed by OWNERS file too. A reviewer in an OWNERS file can approve(by adding lgtm label) any file in that directory and its sub-directories, but he/she can't approve the files in the parent directory and any other sibling directories. This is the big change to before. The old mechanism is that any one of collaborators which are managed by the git platform such as Gitee, Github can add lgtm label. The purpose is to let the reviewer work as approver and make each files at different level directories reviewed by different reviewers.
4. How to add label 'lgtm' The process is also like approve process, see the example of adding approved label above.
In summary, both the approver and reviewer will be managed by OWNERS file and their working mechanisms are also the same. Appreciated for any suggestions. Thanks!
Best Wishes zeng chen _______________________________________________ Dev mailing list -- dev@openlookeng.io To unsubscribe send an email to dev-leave@openlookeng.io
-
Sundar -
zengchen